Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use crashpad on Windows (6-0-x) #18766

Merged
merged 1 commit into from Jun 14, 2019

Conversation

@zcbenz
Copy link
Member

commented Jun 13, 2019

Backport of #18483.

Notes: Migrate crashReporter to use crashpad on Windows.

@zcbenz zcbenz requested a review from electron/wg-upgrades as a code owner Jun 13, 2019

@zcbenz zcbenz added the backport label Jun 13, 2019

@trop trop bot referenced this pull request Jun 13, 2019

Merged

fix: use crashpad on Windows #18483

6 of 6 tasks complete

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 13, 2019

@codebytere
Copy link
Member

left a comment

cc @deepak1556 @nitsakh for second approval!

@codebytere codebytere added the 6-0-x label Jun 13, 2019

@miniak miniak force-pushed the use-crashpad-6-0-x branch from 51f8004 to 3d6430d Jun 13, 2019

Show resolved Hide resolved DEPS

dismissing in order to merge, conflict was resolved --> #18766 (comment)

@codebytere codebytere merged commit d3f7bdd into 6-0-x Jun 14, 2019

10 of 14 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
electron-arm-testing Build #20190613.31 failed
Details
electron-arm64-testing Build #20190613.32 failed
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 14, 2019

Release Notes Persisted

Migrate crashReporter to use crashpad on Windows.

@codebytere codebytere deleted the use-crashpad-6-0-x branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.