Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide the frame URL with permission requests and checks #18772

Conversation

@trop
Copy link
Contributor

commented Jun 13, 2019

Backport of #18757

See that PR for details.

Notes: Added requestingUrl and isMainFrame properties to the permission request and permission check handlers details objects so that apps can check the origin of the requesting frame rather than the root frame.

MarshallOfSound added some commits Jun 12, 2019

feat: provide the frame URL with permission requests and checks
Also provides a handy isMainFrame property to determine if it is an
iframe making the request

@MarshallOfSound MarshallOfSound force-pushed the trop/6-0-x-bp-feat-provide-the-frame-url-with-permission-requests-and-checks-1560449527231 branch from d4a6cf1 to 1bfa30c Jun 14, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 14, 2019

@zcbenz

zcbenz approved these changes Jun 15, 2019

@zcbenz zcbenz merged commit 5a83d9e into 6-0-x Jun 15, 2019

9 of 14 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190614.8 failed
Details
electron-arm64-testing Build #20190614.9 failed
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 15, 2019

Release Notes Persisted

Added requestingUrl and isMainFrame properties to the permission request and permission check handlers details objects so that apps can check the origin of the requesting frame rather than the root frame.

@zcbenz zcbenz deleted the trop/6-0-x-bp-feat-provide-the-frame-url-with-permission-requests-and-checks-1560449527231 branch Jun 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.