Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uncaught TypeError: Cannot set property 'innerText' of null in default-app #18819

Merged
merged 1 commit into from Jun 17, 2019

Conversation

2 participants
@miniak
Copy link
Contributor

commented Jun 15, 2019

Description of Change

100% repro when default-app is used to open a website.

The problem is that the code assumes these elements to be present in the DOM, which is not the case if any other page is loaded.

    <ul class="versions code">
      <li class="electron-version"></li>
      <li class="chrome-version"></li>
      <li class="node-version"></li>
      <li class="v8-version"></li>
    </ul>

Example electron https://www.example.com/
Screen Shot 2019-06-15 at 3 01 50 PM

Checklist

Release Notes

Notes: Fixed Uncaught TypeError: Cannot set property 'innerText' of null in default-app when opening a website.

@miniak miniak added the 5-0-x label Jun 15, 2019

@miniak miniak self-assigned this Jun 15, 2019

@miniak miniak requested review from MarshallOfSound, codebytere and ckerr Jun 15, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 16, 2019

@codebytere codebytere added backport and removed backport labels Jun 17, 2019

@codebytere codebytere merged commit a7c4d21 into 5-0-x Jun 17, 2019

10 of 13 checks passed

Valid Backport Invalid Backport
Details
electron-arm-testing Build #20190615.23 failed
Details
electron-arm64-testing Build #20190615.24 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 17, 2019

Release Notes Persisted

Fixed Uncaught TypeError: Cannot set property 'innerText' of null in default-app when opening a website.

@codebytere codebytere deleted the miniak/fix-default-app-5-0-x branch Jun 17, 2019

@sofianguy sofianguy added this to Fixed in 5.0.5 in 5.0.x Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.