Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert more files to TypeScript #18820

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@miniak
Copy link
Contributor

commented Jun 15, 2019

Description of Change

Convert the following files to TypeScript:

  • lib/common/buffer-utils.js
  • lib/common/clipboard-utils.js
  • lib/common/error-utils.js
  • lib/common/web-view-methods.js
  • lib/browser/devtools.js

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak self-assigned this Jun 15, 2019

@miniak miniak force-pushed the miniak/typescript-helpers branch 2 times, most recently from f12007c to 9f1858b Jun 15, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 16, 2019

@miniak miniak force-pushed the miniak/typescript-helpers branch from 9f1858b to 1840d3a Jun 17, 2019

@miniak miniak requested review from MarshallOfSound and nornagon Jun 17, 2019

@miniak miniak force-pushed the miniak/typescript-helpers branch from 1840d3a to fe4121f Jun 17, 2019

@miniak miniak added the wip label Jun 19, 2019

@miniak miniak force-pushed the miniak/typescript-helpers branch 4 times, most recently from 6d1ec55 to 702173f Jul 6, 2019

@miniak miniak changed the base branch from master to miniak/update-typescript Jul 7, 2019

@miniak miniak force-pushed the miniak/typescript-helpers branch 3 times, most recently from 920ad2f to 55d6e39 Jul 7, 2019

@miniak miniak referenced this pull request Jul 8, 2019
3 of 3 tasks complete

@miniak miniak force-pushed the miniak/update-typescript branch from df88722 to 320fff1 Jul 9, 2019

@miniak miniak force-pushed the miniak/typescript-helpers branch from f525e5d to cb17b41 Jul 9, 2019

@miniak miniak changed the base branch from miniak/update-typescript to master Jul 9, 2019

@miniak miniak force-pushed the miniak/typescript-helpers branch from cb17b41 to 6d8f28a Jul 9, 2019

@miniak miniak removed the wip label Jul 9, 2019

lib/common/buffer-utils.ts Outdated Show resolved Hide resolved
lib/common/buffer-utils.ts Show resolved Hide resolved
lib/common/error-utils.ts Outdated Show resolved Hide resolved
lib/common/error-utils.ts Outdated Show resolved Hide resolved

@miniak miniak force-pushed the miniak/typescript-helpers branch 2 times, most recently from 4cd715d to fb9f950 Jul 9, 2019

@miniak miniak requested a review from nornagon Jul 9, 2019

lib/common/buffer-utils.ts Outdated Show resolved Hide resolved
lib/common/buffer-utils.ts Show resolved Hide resolved

@miniak miniak force-pushed the miniak/typescript-helpers branch from fb9f950 to 437af92 Jul 12, 2019

@miniak miniak requested a review from nornagon Jul 12, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@nornagon can you please check again?

@nornagon nornagon merged commit c79613b into master Jul 17, 2019

7 of 11 checks passed

appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 17, 2019

No Release Notes

@nornagon nornagon deleted the miniak/typescript-helpers branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.