Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add security warning for the remote module #18822

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Jun 15, 2019

Description of Change

Add security warning for remote module with remote content.
It also fixes the comments referencing docs/tutorial/security.md.

Checklist

Release Notes

Notes: Added security warning for remote module with remote content.

@miniak miniak requested a review from electron/wg-security Jun 15, 2019
@miniak miniak self-assigned this Jun 15, 2019
@miniak miniak force-pushed the miniak/security-warnings-remote-module branch 2 times, most recently from 5e34ca7 to 69a987b Jun 15, 2019
@miniak miniak force-pushed the miniak/security-warnings-remote-module branch from 69a987b to 6fee2b9 Jun 15, 2019
@miniak miniak changed the title feat: add security warning for remote module with remote content feat: add security warning for remote module Jun 15, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 16, 2019
@zcbenz
zcbenz approved these changes Jun 17, 2019
@miniak miniak changed the title feat: add security warning for remote module feat: add security warning for the remote module Jun 17, 2019
@codebytere codebytere merged commit 0af3548 into master Jun 17, 2019
13 checks passed
13 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190615.27 succeeded
Details
electron-arm64-testing Build #20190615.28 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 17, 2019

Release Notes Persisted

Added security warning for remote module with remote content.

@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Jun 17, 2019

@miniak does this need backports?

@codebytere codebytere deleted the miniak/security-warnings-remote-module branch Jun 17, 2019
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Jun 17, 2019

@miniak does this need backports?

@miniak

This comment has been minimized.

Copy link
Contributor Author

miniak commented Jun 18, 2019

/trop run backport-to 6-0-x

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jun 18, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "6-0-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jun 18, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@miniak

This comment has been minimized.

Copy link
Contributor Author

miniak commented Jun 18, 2019

@electron/wg-security do you think we should backport it anywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.