Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use effectiveAppearance to check dark mode on mojave and above #18852

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Jun 17, 2019

Backport of #18845

See that PR for details.

Notes: Fixed issue on macOS Catalina where the tray icon would be highlighted incorrectly and sometimes invisible.

fix: use effectiveAppearance to check dark mode on mojave and above (#…
…18666)

* fix: use effectiveAppearance to check dark mode on mojave and above

* chore: add forward declarations for dark appearance

@codebytere codebytere merged commit f09f926 into 5-0-x Jun 18, 2019

10 of 13 checks passed

build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190617.55 failed
Details
electron-arm64-testing Build #20190617.51 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 18, 2019

Release Notes Persisted

Fixed issue on macOS Catalina where the tray icon would be highlighted incorrectly and sometimes invisible.

@codebytere codebytere deleted the trop/5-0-x-bp-fix-use-effectiveappearance-to-check-dark-mode-on-mojave-and-above-1560812083433 branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.