Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: correct triggeredByAccelerator Event property behavior #18865
Description of Change
This PR swaps out the
The business logic to detect
Furthermore, a broken test was changed to properly detect that the accelerator registers properly and that the
It seems like CI is failing the newly added tests on
Will try to debug this on a Linux/Windows machine soon.
The root cause of the failing test was very much related to the problem that @ckerr was referring to here #18865 (comment). After debugging the test code with @jkleinsc, it seems like the
Observed behaviour: RobotJS logs its keystrokes into the console rather than into the test app (observe
Things that have been attempted to fix this:
Elsewhere in the code, there's only one other instance of RobotJS, which also skips CI on Mac and Windows.
Therefore, I'm advocating to just skip the CI for the accelerator tests for now. Would that be okay?