Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delay handling occlusion events to avoid flicker on macOS #18885

Conversation

@trop
Copy link
Contributor

commented Jun 19, 2019

Backport of #18661

See that PR for details.

Notes: Fixed random flicker that occurred on macOS when performing fullscreen or workspace transitions

chore: add debounce on the updateWebContentsVisibility method to ensu…
…re quick changes in occlusion do not result in flickering

@trop trop bot requested a review from electron/wg-upgrades as a code owner Jun 19, 2019

@trop trop bot added 6-0-x backport labels Jun 19, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 19, 2019

@codebytere codebytere force-pushed the trop/6-0-x-bp-fix-delay-handling-occlusion-events-to-avoid-flicker-on-macos-1560973896379 branch from 39dfffc to e598e80 Jun 20, 2019

@MarshallOfSound MarshallOfSound force-pushed the trop/6-0-x-bp-fix-delay-handling-occlusion-events-to-avoid-flicker-on-macos-1560973896379 branch from cafdaad to 708cb52 Jun 20, 2019

@codebytere codebytere merged commit 03be4c6 into 6-0-x Jun 21, 2019

12 of 14 checks passed

electron-arm-testing Build #20190620.54 failed
Details
electron-arm64-testing Build #20190620.54 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 21, 2019

Release Notes Persisted

Fixed random flicker that occurred on macOS when performing fullscreen or workspace transitions

@codebytere codebytere deleted the trop/6-0-x-bp-fix-delay-handling-occlusion-events-to-avoid-flicker-on-macos-1560973896379 branch Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.