Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app.getAppPath() returning default-app path when no package.json found #18888

Conversation

@trop
Copy link
Contributor

commented Jun 19, 2019

Backport of #18763

See that PR for details.

Notes: Fixed app.getAppPath() returning default-app path when running electron app with no package.json or electron app/index.js. Now the directory containing the executed file is returned.

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 19, 2019

@codebytere codebytere merged commit 503da64 into 6-0-x Jun 21, 2019

12 of 14 checks passed

electron-arm-testing Build #20190619.38 failed
Details
electron-arm64-testing Build #20190619.37 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 21, 2019

Release Notes Persisted

Fixed app.getAppPath() returning default-app path when running electron app with no package.json or electron app/index.js. Now the directory containing the executed file is returned.

@codebytere codebytere deleted the trop/6-0-x-bp-fix-app-getapppath-returning-default-app-path-when-no-package-json-found-1560980080192 branch Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.