Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: session.{clearCache,getCacheSize} nws13n #18898

Merged
merged 1 commit into from Jun 21, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

commented Jun 20, 2019

Description of Change

Fixes #17189.

Backport of #17969. We haven't promisified this in 5 so this is a callbackified version of that PR.

cc @nornagon

Checklist

Release Notes

Notes: Fix an issue where session.getCacheSize would never call its callback.

@codebytere codebytere requested a review from nornagon Jun 20, 2019

@codebytere codebytere force-pushed the bp-nw-cache-size-5 branch from a5770cc to e6b1d18 Jun 20, 2019

@codebytere codebytere force-pushed the bp-nw-cache-size-5 branch from e6b1d18 to 4d1d436 Jun 20, 2019

@codebytere codebytere changed the title [wip] refactor: session.{clearCache,getCacheSize} nws13n refactor: session.{clearCache,getCacheSize} nws13n Jun 20, 2019

@codebytere codebytere removed the wip label Jun 20, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 21, 2019

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

Failing spec on linux is:

webContents module create() does not crash on exit - does not crash on exit

which is not affected by the codepaths changed in this PR and which i would therefore say is a flake.

@codebytere codebytere merged commit 385e548 into 5-0-x Jun 21, 2019

10 of 14 checks passed

Valid Backport Invalid Backport
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190621.6 failed
Details
electron-arm64-testing Build #20190621.6 failed
Details
Artifact Comparison No Changes
Details
Backportable? - 4-2-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 21, 2019

Release Notes Persisted

Fix an issue where session.getCacheSize would never call its callback.

@codebytere codebytere deleted the bp-nw-cache-size-5 branch Jun 21, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

I have automatically backported this PR to "4-2-x", please check out #18921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.