Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: app.moveToApplicationsFolder conflict handling #18916
Description of Change
We want to keep default move conflict handling behavior in that it's still what most users would expect, but there exist edge cases in which users may not want to be forced into that behavior.
This thus introduces an optional conflict handler that allows developers access to more granular move actions. They could now allow the user to choose whether to delete an existing app in favor of the current one being moved, or whether to quit the current app and focus on the existing one should it both exist and be running. I added a fair amount of new documentation outlining this behavior, but if there are things users may benefit from seeing examples of or nuances that should be added please leave feedback!
Notes: Added an optional conflict handling callback to
@codebytere I feel this PR completely solves a specific issue: being able to show a dialog in case a conflict arises.
But if an app is already present and running I guess what most people would want to do is quit the old app and then move the new one in, this PR at best would allow me to show the user an error, but what if I just want to quit the old app and proceed? Which would be the most common scenario under this situation IMHO. Is/shoudn't there be an easy way to do that?
And shouldn't an asynchronous
Also if I don't provide a
@fabiospampinato this PR was created to address some use cases; it's unlikely we ever be able to cover all of them.
No, it does not change previous behavior. All new behavior is optional as documented.
I am happy to continue to iterate on this functionality as time permits.
The previous behavior was to return