Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Node.js v12.4.0 #18924

Merged
merged 12 commits into from Jul 16, 2019

Conversation

@codebytere
Copy link
Member

commented Jun 21, 2019

Description of Change

Update our Node dependency to v12.4.0.

Checklist

Release Notes

Notes: Updated Node dependency to v12.4.0.

@codebytere codebytere changed the title chore: update to node 12.4.0 chore: update to Node.js v12.4.0 Jun 21, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 22, 2019

@MarshallOfSound MarshallOfSound force-pushed the update-node-12.4 branch from 2c14e29 to 2618fa9 Jun 29, 2019

@codebytere codebytere force-pushed the update-node-12.4 branch from 5e4c494 to 33bd332 Jul 3, 2019

@MarshallOfSound MarshallOfSound force-pushed the update-node-12.4 branch from 33bd332 to afefa92 Jul 4, 2019

@MarshallOfSound MarshallOfSound marked this pull request as ready for review Jul 4, 2019

@MarshallOfSound MarshallOfSound force-pushed the update-node-12.4 branch from 365dd1d to bff1bba Jul 15, 2019

codebytere and others added some commits Jun 21, 2019

fix: let node do it's thing to the all contexts
We need to let node know about all the contexts that Chromium creates for the renderer processes so that it does not crash when trying to access primordials.  Similar to node::NewContext but with an existing context
fix: ensure that _noBrowserGlobals is set before the node bootstrappe…
…r runs

Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>

@MarshallOfSound MarshallOfSound force-pushed the update-node-12.4 branch from eae11d7 to 89d678b Jul 16, 2019

@@ -320,6 +328,12 @@ node::Environment* NodeBindings::CreateEnvironment(
node::Environment* env = node::CreateEnvironment(
node::CreateIsolateData(context->GetIsolate(), uv_loop_, platform),
context, args.size(), c_argv.get(), 0, nullptr);
DCHECK(env);

// Clean up the global _noBrowserGlobals that we unironically injected into

This comment has been minimized.

Copy link
@nornagon

nornagon Jul 16, 2019

Contributor

🙃

@MarshallOfSound MarshallOfSound merged commit aa211c6 into master Jul 16, 2019

11 of 12 checks passed

Backportable? - 6-0-x Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 16, 2019

Release Notes Persisted

Updated Node dependency to v12.4.0.

@MarshallOfSound MarshallOfSound deleted the update-node-12.4 branch Jul 16, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #19281

MarshallOfSound added a commit that referenced this pull request Jul 16, 2019

feat: update to node 12.4 (#19270) (#19281)
* feat: update to node 12.4 (#19270)

This points our node repo at upstream (nodejs/node) and uses the base node tag as the target ref.  We then use our existing patch system and patch files to apply our changes on top of node.  This unifies how we patch upstream repos and makes our node patches easier to reason, view, understand and most importantly reduce.

This also upgrades Electron 6 to Node 12.4

Notes: Upgraded to Node 12.4

* chore: cherry pick changes required for node 12.4 from #18924

@sofianguy sofianguy added this to Fixed in 6.0.0-beta.14 in 6.0.x Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.