Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove scripts in the tools dir that are unused #18944

Merged
merged 1 commit into from Jun 23, 2019

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

commented Jun 23, 2019

I'm cleaning up the tools and scripts folder, looks like most of the stuff in tools was from the GYP days or sometimes even earlier, no need to keep it around anymore

Part 1 of N

Notes: no-notes

@codebytere

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

before we ditch these, do we know where they were all used at one point in time so we can be sure we don't need them anymore?

@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

@codebytere Yeah I traced them all to be sure, I'll put a quick list below.

  • atom_source_root.js used in GYP bootstrap for < 1.8
  • dump-version-info.js replaced by metadumper
  • get-endianess used in ancient GYP bootstrap
  • pkg-config-wrapper used in GYP sysroot land
  • rewrite_dirs used in GYP sysroot land
  • sysroot_ld_paths more GYP sysroot stuff
  • make_locale_paks used in GYP building days, GN / chromium build scripts does this for us now
  • run-electron yeah idk, back in GYP days, it points back to out/D which is a GYP thing

@MarshallOfSound MarshallOfSound merged commit 79ac99c into master Jun 23, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190623.1 succeeded
Details
electron-arm64-testing Build #20190623.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 23, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the remove-unused-tools branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.