Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make isDarkMode correctly detect dark mode in the auto setting on catalina #18958

Conversation

@trop
Copy link
Contributor

commented Jun 24, 2019

Backport of #18949

See that PR for details.

Notes: systemPreferences.isDarkMode() now correctly detects dark mode on macOS Catalina

@codebytere codebytere merged commit 74b06ab into 6-0-x Jun 24, 2019

13 of 14 checks passed

electron-arm-testing Build #20190624.14 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190624.13 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 24, 2019

Release Notes Persisted

systemPreferences.isDarkMode() now correctly detects dark mode on macOS Catalina

@codebytere codebytere deleted the trop/6-0-x-bp-fix-make-isdarkmode-correctly-detect-dark-mode-in-the-auto-setting-on-catalina-1561396675601 branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.