Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override the timers module impls to activate the uv loop #18961

Conversation

@trop
Copy link
Contributor

commented Jun 24, 2019

Backport of #18948

See that PR for details.

Notes: Fixed issue where require('timers').setTimeout would sometimes never fire in the renderer process

@MarshallOfSound MarshallOfSound merged commit 212c6b1 into 6-0-x Jun 24, 2019

13 of 14 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190624.15 succeeded
Details
electron-arm64-testing Build #20190624.17 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 24, 2019

Release Notes Persisted

Fixed issue where require('timers').setTimeout would sometimes never fire in the renderer process

@MarshallOfSound MarshallOfSound deleted the trop/6-0-x-bp-fix-override-the-timers-module-impls-to-activate-the-uv-loop-1561396730764 branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.