Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override the timers module impls to activate the uv loop #18965

Merged
merged 1 commit into from Jun 25, 2019

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

commented Jun 24, 2019

Backport of #18948.

See that PR for details

Notes: Fixed issue where require('timers').setTimeout would sometimes never fire in the renderer process

@codebytere codebytere merged commit c979c90 into 5-0-x Jun 25, 2019

12 of 14 checks passed

build-linux Workflow: build-linux
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Backportable? - 4-2-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190624.35 succeeded
Details
electron-arm64-testing Build #20190624.35 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 25, 2019

Release Notes Persisted

Fixed issue where require('timers').setTimeout would sometimes never fire in the renderer process

@codebytere codebytere deleted the auto-activate-timers-5 branch Jun 25, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

I have automatically backported this PR to "4-2-x", please check out #18968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.