Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not remove node globals when context isolation is enabled #18967

Merged
merged 1 commit into from Jun 28, 2019

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Jun 24, 2019

Notes: Node.JS globals (process, Buffer, etc.) are no longer removed from the global scope if you have contextIsolation enabled as it is safe for those variables to still exist in their isolated world

@deepak1556 deepak1556 requested a review from zcbenz Jun 25, 2019
@zcbenz
zcbenz approved these changes Jun 25, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 25, 2019
@codebytere codebytere merged commit 6eed4a9 into master Jun 28, 2019
13 checks passed
13 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190625.1 succeeded
Details
electron-arm64-testing Build #20190625.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 28, 2019

Release Notes Persisted

Node.JS globals (process, Buffer, etc.) are no longer removed from the global scope if you have contextIsolation enabled as it is safe for those variables to still exist in their isolated world

@codebytere codebytere deleted the do-not-remove-globals-when-isolated branch Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.