Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a series of new printing options #18984

Merged
merged 1 commit into from Jun 30, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jun 25, 2019

Description of Change

Resolves #7849.

Adds a large host of new options to customize webContents.print().

h/t @brenca for his previous work on this!

Checklist

Release Notes

Notes: Added a selection of new printing customization options.

@codebytere codebytere added the wip label Jun 25, 2019
@codebytere codebytere requested review from deepak1556 and brenca Jun 25, 2019
@codebytere codebytere force-pushed the enhance-printing branch from e6b074c to 74fc314 Jun 26, 2019
@codebytere codebytere force-pushed the enhance-printing branch from 74fc314 to 405b320 Jun 26, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 26, 2019
@codebytere codebytere changed the title [wip] feat: add a series of new printing options feat: add a series of new printing options Jun 27, 2019
@codebytere codebytere removed the wip label Jun 27, 2019
@zcbenz
zcbenz approved these changes Jun 28, 2019
@brenca
brenca approved these changes Jun 28, 2019
@codebytere codebytere force-pushed the enhance-printing branch from 405b320 to f274d57 Jun 28, 2019
@popod

This comment has been minimized.

Copy link
Contributor

popod commented Jun 29, 2019

@codebytere printing will soon be very nice with electron :) Thanks for that !

Just a little comment about this PR. Is it expected that they is no options to choose the "paper format" (A4, Letter, A5, Legal, ...) ?

This could be something like the pageSize option which is available with webContents.printToPDF().

Should I create a new issue for that or could you easily add this option in this PR ?

@codebytere

This comment has been minimized.

Copy link
Member Author

codebytere commented Jun 30, 2019

@popod not in this PR, but i can see what I might do in a follow-up!

@codebytere codebytere merged commit 0348b60 into master Jun 30, 2019
12 of 13 checks passed
12 of 13 checks passed
build-linux Workflow: build-linux
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190628.30 succeeded
Details
electron-arm64-testing Build #20190628.30 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 30, 2019

Release Notes Persisted

Added a selection of new printing customization options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.