Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert webContents primitives to properties #18998

Merged
merged 2 commits into from Jul 3, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jun 26, 2019

Description of Change

Convert webContents primitive getters and setters to bespoke properties.

cc @miniak @MarshallOfSound

Checklist

Release Notes

Notes: Converted webContents primitive getters and setters to bespoke properties.

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Jun 26, 2019
@codebytere codebytere force-pushed the webcontents-primitives branch 5 times, most recently from 7e91e0a to 4e1040d Jul 1, 2019
@codebytere codebytere force-pushed the webcontents-primitives branch from 4e1040d to 5b50115 Jul 2, 2019
@codebytere codebytere marked this pull request as ready for review Jul 2, 2019
@codebytere codebytere requested review from nornagon and miniak Jul 2, 2019
spec/api-web-contents-spec.js Outdated Show resolved Hide resolved
spec/ts-smoke/electron/main.ts Outdated Show resolved Hide resolved
spec/ts-smoke/electron/main.ts Outdated Show resolved Hide resolved
@miniak
miniak approved these changes Jul 2, 2019
@codebytere codebytere force-pushed the webcontents-primitives branch from 2d56d4c to 6fef89a Jul 3, 2019
@codebytere codebytere merged commit 8782d06 into master Jul 3, 2019
13 checks passed
13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190703.13 succeeded
Details
electron-arm64-testing Build #20190703.13 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 3, 2019

Release Notes Persisted

Converted webContents primitive getters and setters to bespoke properties.

@codebytere codebytere deleted the webcontents-primitives branch Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.