Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: manual management of detached WebContents #19011

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
6 participants
@alexstrat
Copy link
Contributor

commented Jun 27, 2019

Description of Change

Following discussions in #18976, revert #14487

This CL that landed with 76.0.3783.1 made #14487 not useful anymore.

I did follow the reproduction steps explained in #14211 and could not reproduce the issue.

cc @zcbenz @deepak1556

Checklist

Release Notes

Notes: Revert #14487

@alexstrat alexstrat requested a review from electron/wg-upgrades as a code owner Jun 27, 2019

@@ -460,7 +455,7 @@ WebContents::~WebContents() {
} else {
// Destroy WebContents asynchronously unless app is shutting down,
// because destroy() might be called inside WebContents's event handler.
DestroyWebContents(true /* async */);
DestroyWebContents(!IsGuest() /* async */);

This comment has been minimized.

Copy link
@alexstrat

alexstrat Jun 27, 2019

Author Contributor

I'm not sure !IsGuest() is what we expect here. @zcbenz opinion?

This comment has been minimized.

Copy link
@zcbenz

zcbenz Jun 28, 2019

Member

It is correct.

@alexstrat

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

@deepak1556 you were suggesting to add tests: what kind of tests would you suggest?

@zcbenz

zcbenz approved these changes Jun 28, 2019

@@ -460,7 +455,7 @@ WebContents::~WebContents() {
} else {
// Destroy WebContents asynchronously unless app is shutting down,
// because destroy() might be called inside WebContents's event handler.
DestroyWebContents(true /* async */);
DestroyWebContents(!IsGuest() /* async */);

This comment has been minimized.

Copy link
@zcbenz

zcbenz Jun 28, 2019

Member

It is correct.

@zcbenz

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

@deepak1556 you were suggesting to add tests: what kind of tests would you suggest?

I couldn't find a way to programmably test the original issue, it seemed to be only visually noticeable.

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 28, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

@alexstrat can you rebase this PR?

@alexstrat alexstrat force-pushed the alexstrat:revert-PR14487 branch from 4e083d9 to 7ac0fd8 Jul 7, 2019

@alexstrat

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

@jkleinsc rebase done

@zcbenz

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

This PR needs an approval from @electron/wg-upgrades.

@deepak1556

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

@alexstrat sorry about this but can you rebase again on master to pull in #19127 that should fix the macOS build error. Thanks!

@alexstrat alexstrat force-pushed the alexstrat:revert-PR14487 branch from 7ac0fd8 to 7fad4f3 Jul 8, 2019

@alexstrat

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@ryzokuken
Copy link
Member

left a comment

LGTM

@codebytere codebytere changed the title refactor: revert electron/electron#14487 revert: manual management of detached WebContents Jul 11, 2019

@codebytere

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

macOS failure is expected, as code-signing tests fail on PRs from forks.
will merge once linux CI has passed.

@jkleinsc jkleinsc merged commit e26f366 into electron:master Jul 11, 2019

8 of 9 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 11, 2019

Release Notes Persisted

Revert #14487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.