Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move some browser window specs to the main process #19089

Merged
merged 7 commits into from Jul 8, 2019

Conversation

Projects
None yet
3 participants
@nornagon
Copy link
Contributor

commented Jul 2, 2019

Description of Change

Steadily marching towards removing usage of remote in tests that aren't trying to test remote.

Checklist

Release Notes

Notes: none

@nornagon nornagon force-pushed the move-browser-window-specs branch from bfc08e9 to b8a07bb Jul 2, 2019

nornagon and others added some commits Jul 3, 2019

@DeerMichel
Copy link
Member

left a comment

LGTM :)

@@ -1079,4 +1080,302 @@ describe('BrowserWindow module', () => {
})
})

describe('BrowserWindow.setAutoHideCursor(autoHide)', () => {
let w = null as unknown as BrowserWindow

This comment has been minimized.

Copy link
@DeerMichel

DeerMichel Jul 3, 2019

Member

well 🙈 - i'd still prefer just as any but i think that's personal taste too

@nornagon nornagon merged commit c3ae476 into master Jul 8, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190708.18 succeeded
Details
electron-arm64-testing Build #20190708.18 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 8, 2019

No Release Notes

@nornagon nornagon deleted the move-browser-window-specs branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.