Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement net module with NetworkService #19094

Merged
merged 23 commits into from Jul 4, 2019

Conversation

Projects
None yet
2 participants
@zcbenz
Copy link
Member

commented Jul 3, 2019

Description of Change

Refs #15791.

This PR adds NetworkService implementation for net module, all tests are passing with NetworkService enabled.

Checklist

Release Notes

Notes: no-notes

@zcbenz zcbenz requested a review from deepak1556 Jul 3, 2019

// Only emit error when there is no previous failure.
// This is to align with the behavior of non-NetworkService implementation.
if (!(request_state_ & STATE_FAILED))
EmitRequestError(net::ErrorToString(loader_->NetError()));

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Jul 3, 2019

Member

Should response_state_ be set to STATE_FAILED in the else block ? At the moment I see that response_state_ only toggles between STATE_STARTED and STATE_FINISHED , there is no indication of STATE_ERROR but we do check for this in Cancel and other places.

This comment has been minimized.

Copy link
@zcbenz

zcbenz Jul 3, 2019

Author Member

Nice catch. The SimpleURLLoader does not distinguish between response errors and request errors, so I have pushed a change to emit error depending on current state.

@deepak1556
Copy link
Member

left a comment

👍

@deepak1556

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Can you rebase on master before merging and fix the compile error that will be triggered because of api change from latest chromium https://chromium-review.googlesource.com/c/chromium/src/+/1660393 .

@deepak1556 deepak1556 referenced this pull request Jul 4, 2019

Draft

Fix: tests and api with network service enabled #19107

0 of 6 tasks complete

@zcbenz zcbenz force-pushed the net-module-ns branch from ab397bd to 461d562 Jul 4, 2019

@zcbenz zcbenz merged commit 2a37934 into master Jul 4, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190704.7 succeeded
Details
electron-arm64-testing Build #20190704.7 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 4, 2019

No Release Notes

@zcbenz zcbenz deleted the net-module-ns branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.