Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add `toolTip` property for MenuItem (macOS) #19099

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@deermichel
Copy link

deermichel commented Jul 3, 2019

Description of Change

Resolves #17016.

This PR adds the toolTip property to MenuItem which indicates the item's hover text. Currently, this is macOS-only, but as soon as i get my hands on a Win/Linux machine, I'll investigate it there as well.

cc @codebytere @erickzhao

Discussion

Tbh, I've never seen a native app using tooltips on menu items and wouldn't consider it as good style to do so. However, Apple allows it (wondering why ^^) - so we could add it to our API.

Checklist

Release Notes

Notes: Added a property to set tooltips for MenuItems on macOS.

@deermichel deermichel requested a review from codebytere Jul 3, 2019
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Jul 3, 2019

@deermichel we won't be able to backport this to 6, as it's a feature and we're well past the halfway mark of the beta cycle

@deermichel deermichel removed the target/6-1-x label Jul 3, 2019
@deermichel

This comment has been minimized.

Copy link
Author

deermichel commented Jul 3, 2019

No problem 🚀

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 4, 2019
@miniak
miniak approved these changes Jul 5, 2019
@miniak

This comment has been minimized.

Copy link
Contributor

miniak commented Jul 5, 2019

Needs rebase after #19100

Micha Hanselmann
@deermichel deermichel force-pushed the intern/menuitem-tooltip branch from a625848 to 07d5708 Jul 5, 2019
@zcbenz
zcbenz approved these changes Jul 11, 2019
@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Jul 11, 2019

The failing tests are not related to this PR.

@zcbenz zcbenz merged commit 06d4851 into master Jul 11, 2019
12 of 13 checks passed
12 of 13 checks passed
build-mac Workflow: build-mac
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190705.7 succeeded
Details
electron-arm64-testing Build #20190705.7 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 11, 2019

Release Notes Persisted

Added a property to set tooltips for MenuItems on macOS.

@zcbenz zcbenz deleted the intern/menuitem-tooltip branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.