Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ensure that we bundle the correct version of @types/node #19102

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

commented Jul 3, 2019

Noticed we weren't bundling the right major version of the @types/node package. Updated the dependency and added a test to ensure that when we bump node in the future we are using the right types dependency

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from electron/wg-releases as a code owner Jul 3, 2019

@MarshallOfSound MarshallOfSound merged commit 4b674c1 into master Jul 3, 2019

13 of 14 checks passed

Backportable? - 6-0-x Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190703.39 succeeded
Details
electron-arm64-testing Build #20190703.41 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 3, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the fix-bundled-node-types branch Jul 3, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/6-0-x and removed target/6-0-x labels Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.