Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle no env in externsion world set up #19105

Conversation

@trop
Copy link
Contributor

commented Jul 3, 2019

Backport of #19101

See that PR for details.

Notes: Fixed crash that could occur while certain chrome devtools extensions were loaded.

fix: handle no env in externsion world set up
Previously when GetEnvironment returned null this extension setup
crashed.

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 3, 2019

@MarshallOfSound MarshallOfSound merged commit 1c2b8f8 into 6-0-x Jul 3, 2019

12 of 14 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190703.46 succeeded
Details
electron-arm64-testing Build #20190703.46 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 3, 2019

Release Notes Persisted

Fixed crash that could occur while certain chrome devtools extensions were loaded.

@MarshallOfSound MarshallOfSound deleted the trop/6-0-x-bp-fix-handle-no-env-in-externsion-world-set-up-1562193739836 branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.