Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: add object to subscribe notification callback #19110
Description of Change
This change exposes the
Notes: Exposed the value of NSNotification.object to subscribers of notifications in systemPreferences.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
I'm pretty sure that the Mac build failure is a false positive, and that my changes have not introduced a regression.
The error from the CI build is:
And this is for the
It seems like perhaps this is a CI setup failure, rather than anything to do with the code I've changed (which is in system preferences, and not in auto-updating).
@zcbenz -- do you know if there's anything more I need to do to get a passing build, or for this to be merged? I looked at re-running the build on Circle CI, but I don't have permission to do so. The Electron docs suggest that I could ask a releaser to re-run the build, but sadly the link to the list of releasers ((https://github.com/orgs/electron/teams/releasers/members) is a 404 for me.
Perfect -- thanks for the tip!
Is there anything I could do to have this considered for a backport into Electron 6 (or even earlier)? This feature is a blocker for one of my employer's big summer projects, and we'd be happy to dedicate some time to a backport if appropriate.
Unfortunately it's past the feature freeze time for Electron 6, so no new features will be accepted for backport. Once 6 is out though you'll be able to use the 7 beta series. See https://electronjs.org/docs/tutorial/electron-timelines.