Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) #19166

Merged
merged 47 commits into from Jul 24, 2019

Conversation

@electron-bot
Copy link
Collaborator

commented Jul 9, 2019

Updating Chromium to 79eae5b7b2d9dac441ac0182ee160 (lkgr).

See all changes in b8ae827f4fead0b527079194b9899..79eae5b7b2d9dac441ac0182ee160

Notes: no-notes

@electron-bot electron-bot requested a review from electron/wg-upgrades as a code owner Jul 9, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 5b018bf2d5b5b84ab8c6359b5df76 (master) chore: bump chromium to 4a67c72854ace6b52108efd4194d6 (master) Jul 10, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 4a67c72854ace6b52108efd4194d6 (master) chore: bump chromium to dc99dd40427ebb5eb94c03b167098 (master) Jul 11, 2019

@electron-bot electron-bot changed the title chore: bump chromium to dc99dd40427ebb5eb94c03b167098 (master) chore: bump chromium to f446cfff17e89cbaec70cdff73746 (master) Jul 12, 2019

@nitsakh nitsakh force-pushed the roller/chromium/master branch from a042098 to 6d44336 Jul 12, 2019

@electron-bot electron-bot changed the title chore: bump chromium to f446cfff17e89cbaec70cdff73746 (master) chore: bump chromium to 8e6dc3a071a2084820a3dbcb75653 (master) Jul 13, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 8e6dc3a071a2084820a3dbcb75653 (master) chore: bump chromium to c8b7c18c7462c68bc2c0574b495cb (master) Jul 14, 2019

@electron-bot electron-bot changed the title chore: bump chromium to c8b7c18c7462c68bc2c0574b495cb (master) chore: bump chromium to 079e37e1e977b88efa9ebf92938eb (master) Jul 15, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 079e37e1e977b88efa9ebf92938eb (master) chore: bump chromium to 8bc14b8f20c5fe56fc217bb26c7d1 (master) Jul 16, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 8bc14b8f20c5fe56fc217bb26c7d1 (master) chore: bump chromium to 6aa5be6ed6aae83248bacfdb0b518 (master) Jul 17, 2019

@deepak1556 deepak1556 force-pushed the roller/chromium/master branch from f25362b to 3e35768 Jul 18, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 6aa5be6ed6aae83248bacfdb0b518 (master) chore: bump chromium to 9ebc4630806d75a7bb56855dfe406 (master) Jul 18, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 9ebc4630806d75a7bb56855dfe406 (master) chore: bump chromium to 0e4c5e8f4cd9602d6beaf5141fe94 (master) Jul 19, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 0e4c5e8f4cd9602d6beaf5141fe94 (master) chore: bump chromium to 85d4d2756fd9b6e04ba4de096dbe4 (master) Jul 20, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 85d4d2756fd9b6e04ba4de096dbe4 (master) chore: bump chromium to 7460cc6c3f7bdcded3dbcdb35d54b (master) Jul 22, 2019

@deepak1556 deepak1556 self-assigned this Jul 22, 2019

@deepak1556 deepak1556 force-pushed the roller/chromium/master branch 5 times, most recently from 2212e48 to 6ffd1af Jul 22, 2019

@deepak1556

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

/cc @jkleinsc any thoughts on windows ci run having missing .lock files during gclient step ? Seems like a bad cache state.

https://ci.appveyor.com/project/electron-bot/electron-ljo26/builds/26170722
https://ci.appveyor.com/project/electron-bot/electron-ia32-testing/builds/26170726

@electron-bot electron-bot changed the title chore: bump chromium to 7460cc6c3f7bdcded3dbcdb35d54b (master) chore: bump chromium to aa9b160dd03ad8305960b7f4c7087 (master) Jul 23, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

@deepak1556 that is weird as the git cache on the VMs shouldn't have any locks present. I'll add a --break_repo_locks param to the Appveyor CI config which should resolve the issue.

@deepak1556 deepak1556 force-pushed the roller/chromium/master branch from 9da8263 to ee2b35a Jul 23, 2019

@deepak1556 deepak1556 force-pushed the roller/chromium/master branch from ee2b35a to 1194a33 Jul 23, 2019

if (base::EndsWith(command_line->GetProgram().value(),
content::kMacHelperSuffix_renderer,
base::CompareCase::SENSITIVE)) {
flags = content::ChildProcessHost::CHILD_RENDERER;

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Jul 23, 2019

Member

Previously we were checking if its a renderer helper and trying to compare the program paths, but the sole purpose of the check is to ensure that program is launched from a known child helper thats responsible for this process. Have refactored it to make this explicit.

@deepak1556

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

@jkleinsc the lock error still exists.

mojo::GenericPendingReceiver* receiver) {
if (auto factory_receiver =
receiver->As<proxy_resolver::mojom::ProxyResolverFactory>()) {
static base::NoDestructor<proxy_resolver::ProxyResolverFactoryImpl> factory(

This comment has been minimized.

Copy link
@nornagon

nornagon Jul 23, 2019

Contributor

is this copied from somewhere? it seems kinda funky

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Jul 23, 2019

Member

Yup, ChromeContentUtilityClient::RunIOThreadService, our proxy resolver service is managed exactly the way its done in chrome, so the code is identical.

it seems kinda funky

Yeah I can see that at first, but https://chromium-review.googlesource.com/c/chromium/src/+/1703095 and https://bugs.chromium.org/p/chromium/issues/detail?id=977637 details why it makes sense to be this way.

program != plugin_child_path) {
child_path = content::ChildProcessHost::GetChildPath(
content::ChildProcessHost::CHILD_NORMAL);
CHECK(program == child_path)

This comment has been minimized.

Copy link
@nornagon

nornagon Jul 23, 2019

Contributor

CHECK_EQ

#else
base::PathService::Get(content::CHILD_PROCESS_EXE, &child_path);
CHECK(program == child_path);

This comment has been minimized.

Copy link
@nornagon

nornagon Jul 23, 2019

Contributor

here too

@@ -68,7 +68,7 @@ build_script:
--unmanaged
%GCLIENT_EXTRA_ARGS%
"https://github.com/electron/electron"
- gclient sync --with_branch_heads --with_tags --reset
- gclient sync --with_branch_heads --with_tags --reset --break_repo_locks

This comment has been minimized.

Copy link
@nornagon

nornagon Jul 23, 2019

Contributor

This doesn't seem like it should be necessary... we get a new VM every time right? Also, I've seen issues with this flag not doing what it says on my machine.

What precipitated this change?

This comment has been minimized.

Copy link
@jkleinsc

jkleinsc Jul 24, 2019

Contributor

@nornagon it was an attempt to resolve this issue, but it didn't help:
LockError: C:\Users\electron\libcc_cache\chromium.googlesource.com-external-github.com-google-googletest is already locked
From:
https://ci.appveyor.com/project/electron-bot/electron-ia32-testing/builds/26210208

I can spin up a VM and debug further.

This comment has been minimized.

Copy link
@nornagon

nornagon Jul 24, 2019

Contributor

--ignore_repo_locks works better than break, iirc. would be good to know how it managed to get locked though.

This comment has been minimized.

Copy link
@jkleinsc

jkleinsc Jul 24, 2019

Contributor

I just looked at a copy of the master VM. There were a couple of lock files there. I prewarmed the cache and I'm guessing somehow Ieft locks. I have cleaned up the master image so that there aren't any locks on it, so next run we should be good.

@electron-bot electron-bot changed the title chore: bump chromium to aa9b160dd03ad8305960b7f4c7087 (master) chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) Jul 24, 2019

@deepak1556 deepak1556 requested a review from electron/wg-upgrades Jul 24, 2019

@@ -20,3 +20,7 @@ enable_basic_printing = true
angle_enable_vulkan_validation_layers = false

is_cfi = false

# TODO: Remove this and update CI to contain 10.14 SDK once

This comment has been minimized.

Copy link
@MarshallOfSound

@nornagon nornagon merged commit bd526f9 into master Jul 24, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190724.49 succeeded
Details
electron-arm64-testing Build #20190724.49 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 24, 2019

No Release Notes

@nornagon nornagon deleted the roller/chromium/master branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.