Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not wait on promise returned by remote APIs (6-0-x) #19190

Merged
merged 2 commits into from Jul 15, 2019

Conversation

@zcbenz
Copy link
Member

commented Jul 10, 2019

Backport of #18990.

Notes: Fix setting src on <webview> being too slow.

@trop trop bot referenced this pull request Jul 10, 2019

Merged

fix: do not wait on promise returned by remote APIs #18990

5 of 5 tasks complete
@miniak

miniak approved these changes Jul 11, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 11, 2019

@jkleinsc
Copy link
Contributor

left a comment

approving backport on behalf of @electron/wg-releases

@jkleinsc jkleinsc merged commit 742292f into 6-0-x Jul 15, 2019

13 of 14 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190710.5 succeeded
Details
electron-arm64-testing Build #20190710.5 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 15, 2019

Release Notes Persisted

Fix setting src on <webview> being too slow.

@jkleinsc jkleinsc deleted the ipc-handle-promise-6-0-x branch Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.