Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert key -> main change in window delegate listener #19213

Merged
merged 4 commits into from Jul 12, 2019

Conversation

Projects
None yet
4 participants
@erickzhao
Copy link
Member

commented Jul 11, 2019

Description of Change

Fixes #19124

Reverts #18995, which caused a regression (#19124). According to our discussion in #19128 (comment), it would be best to revert the fix for now, especially since this regression has already been backported into 4.2.X, 5.0.X, and 6.0.X.

For now, the test that I wrote in #18995 has also been commented out.

cc @codebytere @zcbenz @nornagon

Checklist

Release Notes

Notes: Reverted change to focus behavior that broke Character Viewer support on macOS.

erickzhao added some commits Jul 11, 2019

Show resolved Hide resolved spec/api-browser-window-spec.js Outdated
@zcbenz

zcbenz approved these changes Jul 12, 2019

@zcbenz zcbenz merged commit 9a42ddd into master Jul 12, 2019

12 of 14 checks passed

Backportable? - 4-2-x Backport Failed
Details
Backportable? - 5-0-x Backport Failed
Details
Artifact Comparison No Changes
Details
Backportable? - 6-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 12, 2019

Release Notes Persisted

Reverted change to focus behavior that broke Character Viewer support on macOS.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

I was unable to backport this PR to "4-2-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

I have automatically backported this PR to "6-0-x", please check out #19221

@erickzhao

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

/trop run backport

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

@erickzhao is not authorized to run PR backports.

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

/trop run backport

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

The backport process for this PR has been manually initiated, here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #19238

@trop

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

A maintainer has manually backported this PR to "4-2-x", please check out #19239

@zcbenz zcbenz deleted the intern/revert-regression-bug branch Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.