Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: <webview> not working in scriptable popups #19218

Conversation

@trop
Copy link
Contributor

commented Jul 12, 2019

Backport of #19198

See that PR for details.

Notes: Fixed <webview> not working in scriptable popups when nativeWindowOpen is enabled.

@trop trop bot referenced this pull request Jul 12, 2019

Merged

fix: <webview> not working in scriptable popups #19198

5 of 5 tasks complete

@trop trop bot added 6-0-x backport labels Jul 12, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 12, 2019

@miniak miniak requested review from zcbenz and deepak1556 Jul 15, 2019

@miniak miniak self-assigned this Jul 15, 2019

@zcbenz

zcbenz approved these changes Jul 16, 2019

@zcbenz zcbenz merged commit fb51509 into 6-0-x Jul 16, 2019

12 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 16, 2019

Release Notes Persisted

Fixed <webview> not working in scriptable popups when nativeWindowOpen is enabled.

@zcbenz zcbenz deleted the trop/6-0-x-bp-fix-webview-not-working-in-scriptable-popups-1562896577719 branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.