Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialize messages being sent over chrome message ports #19252

Conversation

@trop
Copy link
Contributor

commented Jul 15, 2019

Backport of #19104

See that PR for details.

Notes: Uint8Array and Uint16Array can now be sent correctly in Chrome Extension MessagePort instances

fix: serialize messages being sent over chrome message ports
Chrome appears to serialize these messages (see #19070) so we should as
well to be consistent and to avoid bugs with Uint8/16 arrays

Fixes #19070
@zcbenz

zcbenz approved these changes Jul 15, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 15, 2019

@codebytere codebytere merged commit 019e605 into 6-0-x Jul 16, 2019

12 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 16, 2019

Release Notes Persisted

Uint8Array and Uint16Array can now be sent correctly in Chrome Extension MessagePort instances

@codebytere codebytere deleted the trop/6-0-x-bp-fix-serialize-messages-being-sent-over-chrome-message-ports-1563185124312 branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.