Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support css origin in frame.insertCSS #19268

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jul 15, 2019

Description of Change

Closes #19256.

Adds support for cssOrigin in webFrame.insertCSS.

cc @brenca

Checklist

Release Notes

Notes: Added support for CSS origin in webFrame.insertCSS().

@codebytere codebytere requested a review from brenca Jul 15, 2019
@codebytere codebytere force-pushed the add-insert-css-origin branch from 9f992e1 to 7c778bb Jul 15, 2019
@codebytere codebytere force-pushed the add-insert-css-origin branch from 50b3412 to 6fee58d Jul 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 16, 2019
@codebytere codebytere merged commit 3ee95cf into master Jul 17, 2019
8 of 11 checks passed
8 of 11 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
build-linux Workflow: build-linux
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 17, 2019

Release Notes Persisted

Added support for CSS origin in webFrame.insertCSS().

@codebytere codebytere deleted the add-insert-css-origin branch Jul 17, 2019
@sentialx

This comment has been minimized.

Copy link

sentialx commented Jul 20, 2019

@codebytere When this feature will be available?

@codebytere

This comment has been minimized.

Copy link
Member Author

codebytere commented Jul 20, 2019

@sentialx In v7, which branches soon into beta! Keep and eye on the website for an upcoming timeline blog post in the next week or two :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.