Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rotate gesture for macOS #19294

Merged
merged 5 commits into from Jul 23, 2019

Conversation

@erickzhao
Copy link
Member

erickzhao commented Jul 16, 2019

Description of Change

Adds BrowserWindow event support for the rotation trackpad gesture on macOS. This event is emitted constantly between the start and the end of the rotation gesture, and has an attached value corresponding to the degree in angles of the current timespan.

See NSResponder documentation: https://developer.apple.com/documentation/appkit/nsresponder/1525572-rotatewithevent?language=objc

cc @codebytere

Checklist

Release Notes

Notes: Added support for rotation multi-touch gestures on BrowserWindow for macOS.

erickzhao added 2 commits Jul 16, 2019
@erickzhao erickzhao requested review from zcbenz and codebytere Jul 16, 2019
Copy link
Member

codebytere left a comment

needs documentation :)

@erickzhao

This comment has been minimized.

Copy link
Member Author

erickzhao commented Jul 16, 2019

needs documentation :)

Wrote docs and forgot to push them 🤦‍♂

Let me know if the description of the rotation variable in the callback is too confusing/verbose!

@zcbenz
zcbenz approved these changes Jul 17, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 17, 2019
shell/browser/native_window.h Outdated Show resolved Hide resolved
docs/api/browser-window.md Show resolved Hide resolved
@codebytere codebytere requested a review from ckerr Jul 22, 2019
erickzhao added 2 commits Jul 22, 2019
@ckerr
ckerr approved these changes Jul 23, 2019
@ckerr ckerr merged commit 2c383b5 into master Jul 23, 2019
13 checks passed
13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190722.6 succeeded
Details
electron-arm64-testing Build #20190722.6 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 23, 2019

Release Notes Persisted

Added support for rotation multi-touch gestures on BrowserWindow for macOS.

@ckerr ckerr deleted the intern/rotate-gesture branch Jul 23, 2019
@inukshuk inukshuk mentioned this pull request Oct 23, 2019
0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.