Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't execute preload scripts for internal <iframe> in <webview> when nodeIntegrationInSubFrames is enabled #19299

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@miniak
Copy link
Contributor

commented Jul 17, 2019

Description of Change

Backport of #19260

Checklist

Release Notes

Notes: Preload scripts for internal <iframe> in <webview> are not longer executed when nodeIntegrationInSubFrames is enabled.

@miniak miniak force-pushed the miniak/webview-iframe-preload-5-0-x branch from ba5cf0b to 791898e Jul 17, 2019

@zcbenz

zcbenz approved these changes Jul 18, 2019

@zcbenz zcbenz merged commit 69ff736 into 5-0-x Jul 18, 2019

13 of 14 checks passed

electron-arm-testing Build #20190717.13 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190717.13 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 18, 2019

Release Notes Persisted

Preload scripts for internal <iframe> in <webview> are not longer executed when nodeIntegrationInSubFrames is enabled.

@zcbenz zcbenz deleted the miniak/webview-iframe-preload-5-0-x branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.