Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delay handling occlusion events to avoid flicker on macOS #19315

Merged
merged 3 commits into from Jul 18, 2019

Conversation

@jkleinsc
Copy link
Contributor

commented Jul 17, 2019

Description of Change

Manual backport of #18661

See that PR for details.

Checklist

Release Notes

Notes: Fixed random flicker that occurred on macOS when performing fullscreen or workspace transitions

MarshallOfSound and others added some commits Jun 19, 2019

fix: delay handling occlusion events to avoid flicker on macOS (#18661)
* chore: add debounce on the updateWebContentsVisibility method to ensure quick changes in occlusion do not result in flickering

* chore: update old patch headers

(cherry picked from commit 0146cc0)

@jkleinsc jkleinsc requested a review from electron/wg-upgrades as a code owner Jul 17, 2019

@jkleinsc jkleinsc requested a review from MarshallOfSound Jul 17, 2019

@codebytere codebytere added 5-0-x backport and removed new-pr 🌱 labels Jul 17, 2019

@codebytere
Copy link
Member

left a comment

failure to build it seems

@codebytere codebytere merged commit 9b1147c into 5-0-x Jul 18, 2019

13 of 14 checks passed

electron-arm-testing Build #20190718.6 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190718.6 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 18, 2019

Release Notes Persisted

Fixed random flicker that occurred on macOS when performing fullscreen or workspace transitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.