Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run all tests on arm linux platforms #19318

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@jkleinsc
Copy link
Contributor

commented Jul 17, 2019

Description of Change

When we started splitting out tests (eg #17325) we never accomodated for the arm CI which wasn't using script/spec-runner.js because there are (acceptable) failures that happen during yarn/npm install but that script fails if yarn/npm install fails.

This PR updates script/spec-runner.js to look for an environment variable, IGNORE_YARN_INSTALL_ERROR which will allow the spec runner to continue even if there were errors during yarn install.

Running all the tests on arm/arm64 revealed a couple of additional issues that we resolved by modifying our Azure Pipelines agents so that the user that runs the test is now a non-root user.

Additionally arm64 CI was updated to use ubuntu:18.04 instead of ubuntu:16.04 to be consistent with the rest of our linux CI.

Checklist

Release Notes

Notes: no-notes

jkleinsc added some commits Jul 16, 2019

@jkleinsc jkleinsc changed the title test: run all tests on arm platforms test: run all tests on arm linux platforms Jul 17, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 19, 2019

@codebytere codebytere merged commit e389fa7 into master Jul 19, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be merged or rebased
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190717.48 succeeded
Details
electron-arm64-testing Build #20190717.42 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 19, 2019

No Release Notes

@codebytere codebytere deleted the arm-run-all-tests branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.