Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chromium to 76.0.3809.73 (6-0-x) #19324

Merged
merged 3 commits into from Jul 19, 2019

Conversation

electron-bot
Copy link
Contributor

Updating Chromium to 76.0.3809.73.

See all changes in 76.0.3809.70..76.0.3809.73

Notes: Updated Chromium to 76.0.3809.73.

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit failure on macOS (looks like we're hitting a CHECK in webContents creation/navigation)

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted the Helper changes from the master roll --> #18648

@sofianguy sofianguy added this to Blocks Stable in 6.1.x Jul 19, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 19, 2019

Release Notes Persisted

Updated Chromium to 76.0.3809.73.

@MarshallOfSound MarshallOfSound deleted the roller/chromium/6-0-x branch July 19, 2019 04:43
@MarshallOfSound MarshallOfSound moved this from Blocks Stable to Fixed for Next Release in 6.1.x Jul 19, 2019
@sofianguy sofianguy moved this from Fixed for Next Release to Fixed in 6.0.0-beta.15 in 6.1.x Jul 20, 2019
@nornagon
Copy link
Member

Looks like this is causing this CHECK() to fire, at least in Slack:
https://github.com/electron/electron/blame/v6.0.0-beta.15/atom/browser/atom_browser_client.cc#L497

@MarshallOfSound
Copy link
Member

@nornagon Let's talk offline, that CHECK won't fire if we're packaging the app correctly. (We need to package Electron Helper (Renderer).app and Electron Helper (Plugin).app as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.1.x
Fixed in 6.0.0-beta.15
Development

Successfully merging this pull request may close these issues.

None yet

3 participants