Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support `isHighContrastColorScheme()` on macOS #19331

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@deermichel
Copy link

deermichel commented Jul 18, 2019

Description of Change

This PR removes our custom high contrast color scheme detection in favor of Chromium's NativeTheme API.

As a happy side effect, systemPreferences.isHighContrastColorScheme() will now be available on macOS as well.

cc @deepak1556 @erickzhao

Checklist

Release Notes

Notes: Added support for systemPreferences.isHighContrastColorScheme() API on macOS.

Micha Hanselmann added 2 commits Jul 18, 2019
Copy link
Member

MarshallOfSound left a comment

As a happy side effect, systemPreferences.isHighContrastColorScheme() will now be available on macOS as well.

That makes this a feat: and therefore can't / shouldn't be backported

@deermichel deermichel changed the title refactor: use NativeTheme for high contrast detection feat: add support for `isHighContrastColorScheme()` on macOS Jul 18, 2019
@deermichel deermichel changed the title feat: add support for `isHighContrastColorScheme()` on macOS feat: support `systemPreferences.isHighContrastColorScheme()` on macOS Jul 18, 2019
@deermichel deermichel changed the title feat: support `systemPreferences.isHighContrastColorScheme()` on macOS feat: support `isHighContrastColorScheme()` on macOS Jul 18, 2019
@deermichel

This comment has been minimized.

Copy link
Author

deermichel commented Jul 18, 2019

de-feat-ed

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 19, 2019
@codebytere codebytere merged commit dc30b86 into master Jul 19, 2019
15 checks passed
15 checks passed
Backportable? - 5-0-x Cancelled
Details
Backportable? - 6-0-x Cancelled
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190718.12 succeeded
Details
electron-arm64-testing Build #20190718.12 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 19, 2019

Release Notes Persisted

Added support for systemPreferences.isHighContrastColorScheme() API on macOS.

@codebytere codebytere deleted the intern/win-ref-hc-getter branch Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.