Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit always-on-top-changed on macOS #19462

Merged
merged 2 commits into from Jul 27, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jul 25, 2019

Description of Change

The always-on-top-changed event for BrowserWindows showed in documentation as being emitted on macOS only, but in fact it was emitted previously on windows and linux only. This corrects that error so that always-on-top-changed is emitted on all platforms.

cc @ckerr @MarshallOfSound @miniak

Checklist

Release Notes

Notes: Added always-on-top-changed event emission for macOS.

@codebytere codebytere requested review from ckerr, MarshallOfSound and miniak Jul 25, 2019
@codebytere codebytere force-pushed the emit-always-on-top-changed-mac branch 7 times, most recently from 6dce6c1 to d634b27 Jul 25, 2019
@codebytere

This comment has been minimized.

Copy link
Member Author

codebytere commented Jul 25, 2019

NB: when #19463 is merged, the test added therein should remove its platform scoping so as to ensure correct behavior on all platforms.

@codebytere codebytere requested a review from deermichel Jul 26, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 26, 2019
Copy link

deermichel left a comment

Works for me 👍

@codebytere codebytere force-pushed the emit-always-on-top-changed-mac branch from d634b27 to 4200817 Jul 26, 2019
@codebytere codebytere merged commit 6c9d40e into master Jul 27, 2019
13 checks passed
13 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190726.35 succeeded
Details
electron-arm64-testing Build #20190726.35 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 27, 2019

Release Notes Persisted

Added always-on-top-changed event emission for macOS.

@codebytere codebytere deleted the emit-always-on-top-changed-mac branch Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.