Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [wc|bw]-created events do not emit an event object #19465

Merged
merged 2 commits into from Jul 29, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jul 25, 2019

Description of Change

Closes #19455.

Previously, an empty object was emitted in place of an Event during browser-window-created as well as when web-contents-created was emitted.

This led to false assumptions about the nature of the object for end-users. Instead, we now create an empty but legitimate Event and emit that instead.

cc @zcbenz @deepak1556 @nornagon

Checklist

Release Notes

Notes: web-contents-created and browser-window-created no longer emit an empty object in place of Event.

@codebytere codebytere force-pushed the clean-wc-bw-created-evts branch from a26757c to d7ea434 Jul 25, 2019
@codebytere codebytere requested review from nornagon, deepak1556 and zcbenz Jul 25, 2019
Copy link
Member

MarshallOfSound left a comment

Strong -1 here, this API change would be virtually impossible for end-users not using typescript to detect and track down. I'd be in favor of just emitting a real Event object their instead.

Lot's of our native events emit Event object that are usless but we emit them for consistency

@codebytere codebytere force-pushed the clean-wc-bw-created-evts branch from d7ea434 to aa3bd78 Jul 25, 2019
@codebytere codebytere changed the title refactor: [wc|bw]-created events do not emit an event object fix: [wc|bw]-created events do not emit an event object Jul 25, 2019
@codebytere codebytere force-pushed the clean-wc-bw-created-evts branch from aa3bd78 to 92f1360 Jul 26, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 26, 2019
@codebytere

This comment has been minimized.

Copy link
Member Author

codebytere commented Jul 26, 2019

i'm looking into those failures ☝️

@codebytere codebytere force-pushed the clean-wc-bw-created-evts branch from 92f1360 to 5a842ff Jul 29, 2019
@codebytere codebytere merged commit aaca901 into master Jul 29, 2019
13 checks passed
13 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190729.16 succeeded
Details
electron-arm64-testing Build #20190729.16 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 29, 2019

Release Notes Persisted

web-contents-created and browser-window-created no longer emit an empty object in place of Event.

@codebytere codebytere deleted the clean-wc-bw-created-evts branch Jul 29, 2019
cmeeren added a commit to fable-compiler/fable-electron that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.