Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clearing of the backgroundColor property on TouchBarButton #19473

Conversation

@trop
Copy link
Contributor

commented Jul 26, 2019

Backport of #19437

See that PR for details.

Notes: Fixed setting the backgroundColor property on TouchBarButton to default by assigning null after the item is constructed.

@trop trop bot referenced this pull request Jul 26, 2019

Merged

fix: clearing of the backgroundColor property on TouchBarButton #19437

4 of 4 tasks complete

@trop trop bot added 5-0-x backport labels Jul 26, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 26, 2019

@codebytere codebytere merged commit 6b0eaa4 into 5-0-x Jul 30, 2019

12 of 14 checks passed

build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190726.6 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm64-testing Build #20190726.6 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 30, 2019

Release Notes Persisted

Fixed setting the backgroundColor property on TouchBarButton to default by assigning null after the item is constructed.

@codebytere codebytere deleted the trop/5-0-x-bp-fix-clearing-of-the-backgroundcolor-property-on-touchbarbutton-1564134784769 branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.