Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chromium to 32e0bab929213da1019992bf31d29 (master) #19488

Merged
merged 35 commits into from Aug 2, 2019

Conversation

@electron-bot
Copy link
Collaborator

commented Jul 27, 2019

Updating Chromium to 32e0bab929213da1019992bf31d29 (lkgr).

See all changes in 2bbf84f6437b49c70922b65b38bf3..32e0bab929213da1019992bf31d29

Notes: no-notes

@electron-bot electron-bot changed the title chore: bump chromium to a443536f95c3638cc242a14f2437e (master) chore: bump chromium to 13069075ea6c833ccdaf05acee41a (master) Jul 28, 2019

@deepak1556 deepak1556 force-pushed the roller/chromium/master branch from 7bc9355 to f387f46 Jul 29, 2019

@electron-bot electron-bot requested a review from electron/wg-upgrades as a code owner Jul 29, 2019

@deepak1556 deepak1556 force-pushed the roller/chromium/master branch from 73d65b8 to 6a811fd Jul 29, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 13069075ea6c833ccdaf05acee41a (master) chore: bump chromium to 2e6008da2cda4e2ac6b67f57250b3 (master) Jul 29, 2019

nornagon and others added some commits Jul 29, 2019

enable network service by default
things are DCHECKing now

@electron-bot electron-bot changed the title chore: bump chromium to 2e6008da2cda4e2ac6b67f57250b3 (master) chore: bump chromium to 32e0bab929213da1019992bf31d29 (master) Jul 30, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

FYI, cross_site_document_resource_handler.patch and allow_webview_file_url.patch were removed in the most recent update due to the files they patch being deleted with network service refactoring upstream.

@@ -78,7 +78,7 @@ bool ResponseMustBeObject(ProtocolType type) {

// Helper to convert value to Dictionary.
mate::Dictionary ToDict(v8::Isolate* isolate, v8::Local<v8::Value> value) {
if (value->IsObject())
if (!value->IsFunction() && value->IsObject())

This comment has been minimized.

Copy link
@nornagon

nornagon Aug 2, 2019

Contributor

i'm confused what error this fixes?

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Aug 2, 2019

Member

It fixes the test in https://github.com/electron/electron/blob/master/spec-main/api-protocol-spec.ts#L158 . v8::Function inherits from v8::Object so IsObject will be true and the eventual code path is not what we wanted https://v8docs.nodesource.com/node-10.6/d5/d54/classv8_1_1_function.html. In pre-network service code path it was taken care by v8_value_converter https://github.com/electron/electron/blob/master/shell/common/native_mate_converters/v8_value_converter.cc#L359 coincidentally where function type was checked before object type.

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Aug 2, 2019

Member

Maybe I should have documented this

nornagon and others added some commits Aug 2, 2019

@nornagon nornagon merged commit e959137 into master Aug 2, 2019

8 of 11 checks passed

build-linux Workflow: build-linux
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 2, 2019

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.