Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactoring regression in LocationProxy #19494

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@miniak
Copy link
Contributor

commented Jul 28, 2019

Description of Change

Fixes regression introduced in #17591
Screen Shot 2019-07-28 at 11 51 48 AM

Checklist

Release Notes

Notes: Fixed popup.location.* setters when nativeWindowOpen is disabled.

@miniak miniak self-assigned this Jul 28, 2019

@miniak miniak added the 6-0-x label Jul 28, 2019

@miniak miniak force-pushed the miniak/fix-location-proxy-6-0-x branch from 9e6ca36 to b656201 Jul 28, 2019

@miniak miniak marked this pull request as ready for review Jul 28, 2019

@miniak miniak force-pushed the miniak/fix-location-proxy-6-0-x branch from b656201 to a2531f6 Jul 28, 2019

@miniak miniak requested a review from MarshallOfSound Jul 28, 2019

@zcbenz

zcbenz approved these changes Jul 29, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 29, 2019

@codebytere codebytere merged commit 922a4d9 into 6-0-x Jul 29, 2019

12 of 14 checks passed

Valid Backport Invalid Backport
Details
appveyor: win-x64-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190728.2 succeeded
Details
electron-arm64-testing Build #20190728.2 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 29, 2019

Release Notes Persisted

Fixed popup.location.* setters when nativeWindowOpen is disabled.

@codebytere codebytere deleted the miniak/fix-location-proxy-6-0-x branch Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.