Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove GConf and dconf dependencies on linux #19498

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@vially
Copy link
Contributor

commented Jul 28, 2019

Description of Change

GConf and dconf are no longer required by chromium since around version 66 (chromium#768027).

Since Electron is not depending on these libraries directly (e.g.: they were transitive dependencies coming from chromium) I think it's safe to remove them from the Dockerfiles and from the Linux build instructions documentation.

Related discussion: #2727

Resolves #2727

Checklist

Release Notes

Notes: none

@welcome

This comment has been minimized.

Copy link

commented Jul 28, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@deepak1556
Copy link
Member

left a comment

Thanks!

@deepak1556 deepak1556 requested a review from electron/wg-upgrades Jul 29, 2019

@jkleinsc jkleinsc merged commit 0732da1 into electron:master Jul 29, 2019

9 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 29, 2019

No Release Notes

@welcome

This comment has been minimized.

Copy link

commented Jul 29, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@vially vially deleted the vially:remove-gconf-dconf branch Jul 29, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

NB, I updated the release notes here because this change is not user-visible (except for in the docs, changes to which by convention we don't record in release notes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.