Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw better error on getPath('logs') #19514

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jul 29, 2019

Description of Change

Clarifies what default path is created and set when setAppLogsPath() is called with no path parameter. Also throws a more specific error when getPath('logs') is called and setAppLogsPath() has not yet been called.

cc @ckerr

Checklist

Release Notes

Notes: getPath('logs') now throws better error when it fails to find the logs path.

@codebytere codebytere requested a review from ckerr Jul 29, 2019
@codebytere codebytere requested a review from MarshallOfSound Jul 29, 2019
@codebytere codebytere force-pushed the clarify-set-app-log-path branch from db750f7 to 4c9a6c1 Jul 29, 2019
@ckerr
ckerr approved these changes Jul 29, 2019
@codebytere codebytere force-pushed the clarify-set-app-log-path branch from 4c9a6c1 to 7346662 Jul 29, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 30, 2019
@codebytere codebytere merged commit 69646f4 into master Jul 30, 2019
12 of 14 checks passed
12 of 14 checks passed
Artifact Comparison Changes Detected
Details
Backportable? - 6-0-x Backport Failed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190729.36 succeeded
Details
electron-arm64-testing Build #20190729.36 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 30, 2019

Release Notes Persisted

getPath('logs') now throws better error when it fails to find the logs path.

@codebytere codebytere deleted the clarify-set-app-log-path branch Jul 30, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jul 30, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/6-0-x and removed target/6-1-x labels Jul 30, 2019
codebytere added a commit that referenced this pull request Jul 31, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jul 31, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #19545

codebytere added a commit that referenced this pull request Jul 31, 2019
@sofianguy sofianguy added this to Fixed in 6.0.1 in 6.1.x Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6.1.x
Fixed in 6.0.1
2 participants
You can’t perform that action at this time.