Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node to v12.8.0 (master) #19521

Merged
merged 8 commits into from Aug 13, 2019

Conversation

@electron-bot
Copy link
Collaborator

commented Jul 30, 2019

Updating Node.js to v12.8.0.

See all changes in v12.6.0..v12.8.0

Notes: Updated Node.js to v12.8.0.

@nitsakh nitsakh self-assigned this Jul 30, 2019

@electron-bot electron-bot requested a review from electron/wg-upgrades as a code owner Jul 30, 2019

@electron-bot electron-bot changed the title chore: bump node to v12.7.0 (master) chore: bump node to v12.8.0 (master) Aug 7, 2019

@nitsakh nitsakh force-pushed the roller/node/master branch from d3063a0 to 81364ce Aug 12, 2019

electron-bot and others added some commits Jul 30, 2019

chore: update node patches v12.6 to v12.7
Removed patches that are no longer necessary because we've upstreamed few changes already, and 3 way merge others
chore: update node patches v12.7 to v12.8
Removed patches that are no longer necessary because we've upstreamed few changes already, and 3 way merge others
fix: Add patch to revert crypto createhash changes
The original node commit contains changes/calls to functions that are not supported in boringssl.

@nitsakh nitsakh force-pushed the roller/node/master branch from 36355b8 to e1f74a6 Aug 12, 2019

@MarshallOfSound MarshallOfSound merged commit 9713fa0 into master Aug 13, 2019

14 checks passed

Artifact Comparison No Changes
Details
Backportable? - 7-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190813.1 succeeded
Details
electron-arm64-testing Build #20190812.34 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 13, 2019

Release Notes Persisted

Updated Node.js to v12.8.0.

@MarshallOfSound MarshallOfSound deleted the roller/node/master branch Aug 13, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

I have automatically backported this PR to "7-0-x", please check out #19726

@sofianguy sofianguy added this to 7.0.0-beta.3 in 7.0.x Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.