Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tray.focus() #19548

Merged
merged 1 commit into from Aug 9, 2019
Merged

feat: add tray.focus() #19548

merged 1 commit into from Aug 9, 2019

Conversation

@miniak
Copy link
Contributor

@miniak miniak commented Jul 31, 2019

Description of Change

Expose NIM_SETFOCUS

Returns focus to the taskbar notification area. Notification area icons should use this message when they have completed their UI operation. For example, if the icon displays a shortcut menu, but the user presses ESC to cancel it, use tray.focus() to return focus to the notification area.

Checklist

Release Notes

Notes: Added tray.focus(), which returns focus to the taskbar notification area.

@miniak miniak requested review from codebytere and deermichel Jul 31, 2019
@miniak miniak self-assigned this Jul 31, 2019
@miniak miniak force-pushed the miniak/tray-focus branch 2 times, most recently from 9743eb5 to 6dfba28 Jul 31, 2019
shell/browser/ui/win/notify_icon.h Outdated Show resolved Hide resolved
Loading
@miniak miniak force-pushed the miniak/tray-focus branch 2 times, most recently from 5704c97 to 667f4d5 Aug 5, 2019
@miniak miniak requested a review from zcbenz Aug 5, 2019
@zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 6, 2019

It seems that the CI on master branch is failing and this PR is affected.

Loading

zcbenz
zcbenz approved these changes Aug 6, 2019
@miniak miniak force-pushed the miniak/tray-focus branch from 5a49f8f to 135a0a7 Aug 6, 2019
@codebytere codebytere merged commit 03debb4 into master Aug 9, 2019
13 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Aug 9, 2019

Release Notes Persisted

Added tray.focus(), which returns focus to the taskbar notification area.

Loading

@codebytere codebytere deleted the miniak/tray-focus branch Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants