Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use WeakPtr to detect deletion to avoid crash on application menu #19561

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@jkleinsc
Copy link
Contributor

commented Aug 1, 2019

Manual backport of #19257
(cherry picked from commit 4bcf99d)

Description of Change

Checklist

Release Notes

Notes: Fixed crashes when using the application menu on Linux.

fix: use WeakPtr to detect deletion
(cherry picked from commit 4bcf99d)

@jkleinsc jkleinsc requested a review from electron/wg-upgrades as a code owner Aug 1, 2019

@codebytere codebytere added 5-0-x backport and removed new-pr 🌱 labels Aug 1, 2019

@ckerr

ckerr approved these changes Aug 1, 2019

@MarshallOfSound MarshallOfSound merged commit 3af498e into 5-0-x Aug 1, 2019

13 of 14 checks passed

electron-arm-testing Build #20190801.23 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190801.4 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 1, 2019

Release Notes Persisted

Fixed crashes when using the application menu on Linux.

@MarshallOfSound MarshallOfSound deleted the fix-linux-menu-crash-5-0-x branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.