Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make process.uptime() return the correct time #19566

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@DeerMichel
Copy link
Member

commented Aug 1, 2019

Backport of #19436

See that PR for details.

Notes: Fixed process.uptime() returning the wrong time.

@DeerMichel DeerMichel added the 5-0-x label Aug 1, 2019

@DeerMichel DeerMichel requested a review from electron/wg-upgrades as a code owner Aug 1, 2019

@trop trop bot referenced this pull request Aug 1, 2019

Merged

fix: make process.uptime() return the correct time #19436

4 of 4 tasks complete
@DeerMichel

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Please wait for CI 😆

@DeerMichel DeerMichel added backport and removed new-pr 🌱 labels Aug 1, 2019

@DeerMichel DeerMichel changed the title fix: make process.uptime() return the correct time [wip] fix: make process.uptime() return the correct time Aug 1, 2019

@DeerMichel DeerMichel force-pushed the bp-5-uptime branch from 7d5de0c to 271719e Aug 1, 2019

@DeerMichel DeerMichel changed the title [wip] fix: make process.uptime() return the correct time fix: make process.uptime() return the correct time Aug 1, 2019

@MarshallOfSound MarshallOfSound merged commit b4f5c4b into 5-0-x Aug 1, 2019

13 of 14 checks passed

electron-arm-testing Build #20190801.26 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190801.18 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 1, 2019

Release Notes Persisted

Fixed process.uptime() returning the wrong time.

@MarshallOfSound MarshallOfSound deleted the bp-5-uptime branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.