Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clearRecentDocuments role on Windows #19640

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@codebytere
Copy link
Member

commented Aug 6, 2019

Backport of #19599

See that PR for details.

Notes: Fixed the clearRecentDocuments MenuItem role on Windows.

fix: clearRecentDocuments role on Windows (#19599)
* fix: clear recent documents on windows

* chore: don't check for version < win 7

@trop trop bot referenced this pull request Aug 6, 2019

Merged

fix: clearRecentDocuments role on Windows #19599

4 of 4 tasks complete

@codebytere codebytere requested review from zcbenz and electron/wg-releases Aug 6, 2019

@zcbenz

zcbenz approved these changes Aug 6, 2019

@codebytere codebytere merged commit 303559e into 5-0-x Aug 6, 2019

13 of 14 checks passed

build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190806.4 succeeded
Details
electron-arm64-testing Build #20190806.4 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 6, 2019

Release Notes Persisted

Fixed the clearRecentDocuments MenuItem role on Windows.

@codebytere codebytere deleted the clear-doc-win-5 branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.